How can I set a custom header?

[binarykitchen]

On the client side, in the websocket() constructor, how can I set a custom header there? I need this for an API ...

[max-mapper]

you can pass in your own WebSocket instance as the first argument, so just use the browsers builtin new WebSocket and do whatever you want https://github.com/maxogden/websocket-stream/blob/master/stream.js#L12

[binarykitchen]

Yes, I could do that. But the disadvantage is that I have to add ws as a new dependency into my project. I want to avoid this.

Why not have a third parameters headers in the constructor and pass this? See here
https://github.com/theturtle32/WebSocket-Node/pull/58/files

[binarykitchen]

@maxogden Also you'll risk that versions of WS do not match when you add ws as an external dependency. Not so good I think.

[binarykitchen]

@maxogden @mcollina Would you accept a PR?

[mcollina]

It seems it might be just a options argument away, see https://github.com/websockets/ws/blob/master/doc/ws.md#new-wswebsocketaddress-protocols-options. In this line we pass no options https://github.com/maxogden/websocket-stream/blob/master/stream.js#L17.

I am ok for passing through the options, but nothing more. @mafintosh @maxogden what do you think?

[max-mapper]

yea that sounds good to me

[mafintosh]

👍

[binarykitchen]

Ok, now that you have agreed on this, here a small PR #67

@mcollina If you dig deeper, it turns out that WebSocket.js already treats the protocols argument as options under some circumstances, see https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L49