Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options argument to constructor #67

Closed
wants to merge 1 commit into from
Closed

Add options argument to constructor #67

wants to merge 1 commit into from

Conversation

binarykitchen
Copy link
Contributor

No description provided.

@mcollina
Copy link
Collaborator

mcollina commented Mar 9, 2015

Can you please add some more tests for the protocols options?

I needed to do this for node:
https://github.com/mqttjs/MQTT.js/blob/master/lib/connect/ws.js#L11-L13
and this for the browser:
https://github.com/mqttjs/MQTT.js/blob/master/lib/connect/ws.js#L55

@binarykitchen
Copy link
Contributor Author

Ok, maybe few days later. At the moment I am just confused, see this thread websockets/ws#467

@mcollina
Copy link
Collaborator

Is it all clear now? I see the other issue is closed.

@binarykitchen
Copy link
Contributor Author

Yes, all clear now. I should have mentioned that I am after the client on the browser side instead. Query string parameters was the answer for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants