Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cork logic fix for browsers #149

Merged
merged 4 commits into from
Apr 6, 2019

Conversation

scarry1992
Copy link
Contributor

No description provided.

@mcollina
Copy link
Collaborator

I don't understand this change. It should also re-apply those changes I reverted.

Also, do you know how it fixes #148?

@scarry1992
Copy link
Contributor Author

@mcollina, I have no idea what breaks him logic. I don`t change default logic. You can see it in code.

@scarry1992
Copy link
Contributor Author

@mcollina, need more info from @binarykitchen.

@scarry1992
Copy link
Contributor Author

@mcollina, so, what we are doing?

@mcollina
Copy link
Collaborator

We wait for @binarykitchen - I had some doubt on that change from the beginning however I couldn't pinpoint the issue. Seems that change is breaking.

(This PR is not complete - it should re-revert my change).

@scarry1992
Copy link
Contributor Author

if try simple test with @binarykitchen settings - it passed

test('echo works', function(t) {
  var stream = ws('ws://localhost:8343', {objectMode: true, perMessageDeflate: false})
  stream.on('data', function(o) {
    t.ok(Buffer.isBuffer(o), 'is buffer')
    t.equal(o.toString(), 'hello', 'got hello back')
    stream.destroy()
    t.end()
  })
  stream.write(Buffer.from('hello'))
})

@scarry1992
Copy link
Contributor Author

I fixed situation @binarykitchen. But I confused, because in this case I get separate one packet on two socket frames anytime.
First frame of packet:
photo_2019-04-03_19-02-54
Second frame of packet:
photo_2019-04-03_19-02-56
Maybe @mcollina you know what`s going on?

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3ab4fb8 into max-mapper:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants