-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cork logic fix for browsers #149
Conversation
I don't understand this change. It should also re-apply those changes I reverted. Also, do you know how it fixes #148? |
@mcollina, I have no idea what breaks him logic. I don`t change default logic. You can see it in code. |
@mcollina, need more info from @binarykitchen. |
@mcollina, so, what we are doing? |
We wait for @binarykitchen - I had some doubt on that change from the beginning however I couldn't pinpoint the issue. Seems that change is breaking. (This PR is not complete - it should re-revert my change). |
if try simple test with @binarykitchen settings - it passed test('echo works', function(t) {
var stream = ws('ws://localhost:8343', {objectMode: true, perMessageDeflate: false})
stream.on('data', function(o) {
t.ok(Buffer.isBuffer(o), 'is buffer')
t.equal(o.toString(), 'hello', 'got hello back')
stream.destroy()
t.end()
})
stream.write(Buffer.from('hello'))
}) |
I fixed situation @binarykitchen. But I confused, because in this case I get separate one packet on two socket frames anytime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.