fix(JSON): errors with wrong origin operator #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
In error reports, the origin operator was sometimes missing and
sometimes wrong when using JSON, SubJSONOf and SuperJSONOf operators,
as in:
[under operator tdJSONUnmarshaler.resolveOp.func1 at lex.go:156]
Now the location of internal operators, as the ones used by JSON
operators, cannot appear in error reports anymore and so do not mask
the location of user visible operators.
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In error reports, the origin operator was sometimes missing and sometimes wrong when using JSON, SubJSONOf and SuperJSONOf operators, as in:
Now the location of internal operators, as the ones used by JSON operators, cannot appear in error reports anymore and so do not mask the location of user visible operators.