Search every Cookie header for session cookie #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/2 allows a request to have multiple separate Cookie headers with a single Cookie in each, as opposed to HTTP/1.1 behaviour with all cookies concatenated into a single Cookie header. Change the method for searching the session cookie value in a request to account for multiple Cookie headers, and for multiple cookies in a single header. Add unit tests for both scenarios.
|
Thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 allows a request to have multiple separate Cookie headers with a single Cookie in each (RFC 7540) as opposed to HTTP/1.1 behaviour with all cookies concatenated into a single Cookie header. This PR changes the method for searching the session cookie value in a request to account for multiple Cookie headers, and for multiple cookies in a single header. It also adds unit tests for both scenarios where there are multiple cookie values to search through.