Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the HttpOnly value of the cookie #30

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Allow setting the HttpOnly value of the cookie #30

merged 1 commit into from
Feb 22, 2023

Conversation

jmmv
Copy link
Contributor

@jmmv jmmv commented Feb 19, 2023

I'm migrating existing code to Axum. Due to the way the code is written today, the frontend needs to inspect the session cookie but this is not doable with axum-sessions because the HttpOnly property is forcibly set to true. All other frameworks I've looked at (Actix, Warp, and Gin for Go) have allowed me to set this value. I think it'd be good to extend the API to allow customizing this field.

@maxcountryman
Copy link
Owner

Thanks for this!

@maxcountryman maxcountryman merged commit 4c7480a into maxcountryman:main Feb 22, 2023
@jmmv jmmv deleted the httponly branch February 22, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants