Change hard-coded bundleID to automatically retrieved one #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Lavallee <73203142+lavalleeale@users.noreply.github.com>
maxgoedjen
reviewed
Jan 18, 2021
| @@ -24,19 +24,19 @@ struct SecretDetailView<SecretType: Secret>: View { | |||
| .frame(minHeight: 200, maxHeight: .infinity) | |||
| } | |||
|
|
|||
| var dashedKeyName: String { | |||
There was a problem hiding this comment.
Think this file got included by accident. Otherwise looks good. 🙏
maxgoedjen
reviewed
Jan 18, 2021
Secretive.xcodeproj/project.pbxproj
Outdated
| @@ -86,6 +86,7 @@ | |||
| 50BB046B2418AAAE00D6E079 /* EmptyStoreView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 50BB046A2418AAAE00D6E079 /* EmptyStoreView.swift */; }; | |||
| 50C385A3240789E600AF2719 /* OpenSSHReader.swift in Sources */ = {isa = PBXBuildFile; fileRef = 50C385A2240789E600AF2719 /* OpenSSHReader.swift */; }; | |||
| 50C385A52407A76D00AF2719 /* SecretDetailView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 50C385A42407A76D00AF2719 /* SecretDetailView.swift */; }; | |||
| FA0B34672599619E0013AB3A /* bundleIDs.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA0B34662599619E0013AB3A /* bundleIDs.swift */; }; | |||
There was a problem hiding this comment.
Style nit could you rename the bundleIDs.swift to BundleIDs.swift
Removed incorrectly added changes
maxgoedjen
approved these changes
Jan 18, 2021
| @@ -36,7 +36,7 @@ struct SecretDetailView<SecretType: Secret>: View { | |||
| } | |||
|
|
|||
| var keyString: String { | |||
| keyWriter.openSSHString(secret: secret, comment: "\(dashedKeyName)@\(dashedHostName)") | |||
| keyWriter.openSSHString(secret: secret, comment: "\(dashedUserName)@\(dashedHostName)") | |||
There was a problem hiding this comment.
On more change hanging on there – once that's changed though (and CI passes, which is running really slowly tonight for some reason) I'll merge this in. Thanks for the improvements! 🙏
|
OK, I think I understand and changed it. Also, GitHub said that they are changing how macOS runners work so they will be slow to start for a little while. It is not showing the log so I do not know why it failed, it works for me? |
|
👏🙏 |
|
@lavalleeale this is now out in 2.1.1, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is just the bundleID part