wait for new packets on the agent socket after the handler is invoked…

[pfy]

wait for new data on the socket after the handler is called.
ruby net::ssh keeps the agent connection open, but the secretive agent closes the connection :(
this fixes #244

[maxgoedjen]

Hey @pfy, thanks for the fix! This looks correct to me on its face but lemme test it a bit to make sure it doesn't break any other cases.

[maxgoedjen]

Also, any chance you have a test script for this you could share?

[pfy]

Hi @maxgoedjen,
there is a test script in the bug report (in ruby)

require 'net/ssh'
Net::SSH.start('github.com','git',:verbose => :debug) do |ssh|
output = ssh.exec!("hostname")
puts output
end

This fails without the mr and works with the MR.

[maxgoedjen]

Fantastic thanks 🙏

[pfy]

@maxgoedjen how can i help you to get this pr merged ? what is still missing ?

[maxgoedjen]

@pfy sorry nothing, just slipped my mind. Giving it a test now.

[maxgoedjen]

@pfy tested it out with a simple SSH command and it looks as though it may cause an infinite loop. Can you take a look?

Screen.Recording.2021-11-30.at.9.06.43.PM.mov

[maxgoedjen]

I think this is working: #270
Give it a go and let me know if it works for you.

[pfy]

@maxgoedjen this PR works for me. How can I help you to get it merged ?

[maxgoedjen]

@pfy sorry this kinda fell off my radar post-vacation. It's looking good in my testing, I'll create a test build that I'll run for a while (would appreciate if you could test it out for a while until it's released as well). Thanks again for fixing this :)

[maxgoedjen]

@pfy I think you'll need to update this with changes from the base, but should be all good to go then.

[pfy]

ok, i will do that, thanks @maxgoedjen