Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrent requests to socket #495

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

maxgoedjen
Copy link
Owner

@maxgoedjen maxgoedjen commented Dec 11, 2023

Fixes #483
Fixes #392
Also has some cleanup around loggers.

@maxgoedjen maxgoedjen marked this pull request as ready for review December 11, 2023 08:58
@maxgoedjen maxgoedjen merged commit cf58630 into main Dec 11, 2023
2 checks passed
@maxgoedjen maxgoedjen deleted the async_noncopyable_socket branch December 11, 2023 08:59
@maxgoedjen
Copy link
Owner Author

@espadolini @dfsnow @Roguelazer @kdrag0n I think this ought to fix the issues you folks were running into.

Mind testing out the nightly and giving this a 👍 if it's working for you? Would love to hear more if it's not too, obviously ;)
https://github.com/maxgoedjen/secretive/actions/runs/7178520480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent closes connection on short read ssh with forwarded agent fails about 50% of the time
1 participant