Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French localization #506

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

mtardy
Copy link
Contributor

@mtardy mtardy commented Jan 12, 2024

Saw your proposal to write localization in the release notes and since I love using Secretive I did the one for French 🇫🇷!

I just had hesitation on how to translate the agent_(not_)running_notice_title because it's a bit inconsistent between using "Agent" (and click to see the details) and "Secret Agent":

  • agent_not_running_notice_title: Secret Agent Is Not Running
  • agent_running_notice_title: Agent is Running

So I translated that to the French common name with a determinant: "L'agent"

The rest should be fine!

@maxgoedjen
Copy link
Owner

@mtardy this is fantastic, thank you so much for doing this! I'm gonna merge this one now, but I just noticed a handful of strings I missed (mainly around the little password/Touch ID prompts for secured keys) on my first pass. If you don't mind, can I tag you on the followup PR I'll have adding those?

agent_not_running_notice_title: Secret Agent Is Not Running
agent_running_notice_title: Agent is Running

Yeah, there's no real consistency on my part there. I should update that in English as well ;)

@maxgoedjen maxgoedjen merged commit 15d2afd into maxgoedjen:main Jan 12, 2024
1 check passed
@maxgoedjen maxgoedjen mentioned this pull request Jan 12, 2024
@maxgoedjen
Copy link
Owner

Those changes are here: #507
I've also consolidated both localizations (including your previous translations) into one single localization file, so it should be a little simpler to deal with in the future. Thank you again!

@mtardy mtardy deleted the french-localization branch January 13, 2024 12:42
@mtardy
Copy link
Contributor Author

mtardy commented Jan 13, 2024

@mtardy this is fantastic, thank you so much for doing this!

I'm really glad you liked it 😌! I will retake a look then since you merged #507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants