delete redundant (?) loadNamespace() calls

[maxheld83]

There are some instances where I have to use more loadNamespace() than I thought should be necessary (they are all marked with TODO and this issue in the source).

This suggests something is wrong and/or I am not understanding this correctly.

For example:

the ghactions::document() action relies on roxygen, which is (rightfully) in Suggests: for ghactions, not Imports:.
So I have to call:

loadNamespace(package = "roxygen2", lib.loc = Sys.getenv("R_LIBS_ACTION"))
loadNamespace(package = "ghactions", lib.loc = Sys.getenv("R_LIBS_ACTION"))

What I don't understand is why I also have to call

loadNamespace(package = "brew", lib.loc = Sys.getenv("R_LIBS_ACTION"))

before the action will work (otherwise: missing package error).

brew is a dependency of roxygen2 and thus should be loaded when roxygen2 is loaded, no?

So this is weird.

[maxheld83]

this needs to be wrapped in withr::with_libPaths() (or whatever) because downstream dependencies do not inherit the lib.loc from loadNamespace().

[maxheld83]

this is really only part of the problem, remainder in #272