fix CI builds and rework testing harness #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After yet another breaking package update (docker/docker-py#3257), its high time we permanently pin all development packages *and their dependencies* to a known.-good version. pip-tools lets us do that without losing the simple requirements.txt file that allows easy installation, so lets use that.
a little while ago, we were starting to get "imp" import errors in CI builds, which I initially were assumed to be from pytest. In fact, it was the pytest-virtualenv package that we used to generate a virtualenv with a specific ansible version for tests. As there is no easy replacement for this package, and the package itself is stale (no release in 5 years), the testing harness now just installs the desired version of ansible-core straight into the main devel virtualenv. This is a bit ugly as it could interfere with other user tasks, but it leaves the interface the same and helps simplify the test fixture code. Said code also now reliably isolates tes environments from another and the user-wide collections. Combined with package pinning introduced in the previous commit, we should no longer have CI failures due to packages or their deps updating and breaking things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.