-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add archive specific metrics #22
Conversation
Those are indeed interesting use cases! borgmatic-exporter/tests/test_metrics.py Lines 44 to 70 in 0d8a95c
Would be good to see how this can be visualized as well, but this can also be done in the next release. |
missed the tests again... this time I checked at least the coverage but that didn't change and the above tests don't check actual code lines. |
not sure how you choosed the examples for the parameterized test... just added all new metrics for backup-1 and backup-2. |
The values are pretty much random. Please |
Thanks! Will release this shortly. |
@spali I have releases the v0.2.7, do you by any chance have the updated Grafana dashboard that exposes these metrics? |
No, didn't had time to prep some dashboards. But they may be also very individual, especially for alerting. |
Makes sense. |
They are basically free, as already provided by the actual command results.
I find them actually much more interesting than the current sizes of the whole repo... as they allow to conclude to some potential problems or trends...
i.e. :
for sure, this metrics only makes sense if you have one repo per backup and the archives represents snapshots of the same data.... but this was anyway a assumption for using last archive data per repo i.e. in
borg_last_backup_timestamp
.Sorry for not providing the actual dashboard to this metrics, as I didn't had time to make them proper for the PR.