Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Migration #11

Merged
merged 15 commits into from
Jul 25, 2024
Merged

TS Migration #11

merged 15 commits into from
Jul 25, 2024

Conversation

ersbeth
Copy link
Collaborator

@ersbeth ersbeth commented Jun 18, 2024

No description provided.

…ous migration, migrated Convergence and started migrating TriangleUtils
…F and Polygonizers. Some of the examples do not function properly.
… would crash as Primitive.fromJSON throws an error. Also migrated MCTables and fixed a fall-through case in SlidingMarchingCubes
src/blobtree/Element.ts Show resolved Hide resolved
src/blobtree/Element.ts Outdated Show resolved Hide resolved
src/blobtree/Material.ts Show resolved Hide resolved
src/blobtree/Material.ts Outdated Show resolved Hide resolved
src/blobtree/MaxNode.ts Outdated Show resolved Hide resolved
src/utils/TriangleUtils.ts Show resolved Hide resolved
src/utils/TriangleUtils.ts Outdated Show resolved Hide resolved
src/utils/TriangleUtils.ts Outdated Show resolved Hide resolved
src/utils/TriangleUtils.ts Outdated Show resolved Hide resolved
src/utils/TriangleUtils.ts Show resolved Hide resolved
src/blobtree/MaxNode.ts Outdated Show resolved Hide resolved
src/blobtree/MinNode.ts Outdated Show resolved Hide resolved
src/blobtree/RicciNode.ts Outdated Show resolved Hide resolved
src/blobtree/ScaleNode.ts Outdated Show resolved Hide resolved
src/blobtree/areas/AreaScalisTri.ts Outdated Show resolved Hide resolved
@matteoJeulin matteoJeulin changed the title Migration typescript TS Migration Jul 19, 2024
@matteoJeulin matteoJeulin changed the base branch from r3.130 to r4.130 July 19, 2024 13:04
Copy link
Collaborator Author

@ersbeth ersbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes are ok.

Copy link
Collaborator Author

@ersbeth ersbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Copy link
Collaborator Author

@ersbeth ersbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@ersbeth ersbeth merged commit ca282e9 into r4.130 Jul 25, 2024
@ersbeth ersbeth deleted the jeulin/migration-ts branch July 25, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants