-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$SetReplaceTypeGraph #621
$SetReplaceTypeGraph #621
Conversation
ff7c456
to
d13be17
Compare
I'm just going to add a table of contents to the type system README, and then this will be ready for review. |
@taliesinb, @daneelsan, this is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @maxitg and @taliesinb)
Documentation/SymbolsAndFunctions/TypeSystem/$SetReplaceTypeGraph.md, line 13 at r2 (raw file):
```
Not a very informative image hehe. Was this intended because we have yet to define some types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @daneelsan and @taliesinb)
Documentation/SymbolsAndFunctions/TypeSystem/$SetReplaceTypeGraph.md, line 13 at r2 (raw file):
Previously, daneelsan (Daniel Sanchez) wrote…
Not a very informative image hehe. Was this intended because we have yet to define some types?
Yes, that's very much intended. We need to add some types to it (in another PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @daneelsan and @taliesinb)
Changes
$SetReplaceTypeGraph
constant.Examples
Examples below do not work directly because they use fake types. To try them out, do something like
and then evaluate the definitions (line 15 to 81) from
typeSystem.wlt
.Now, check
$SetReplaceTypeGraph
:This change is