Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$SetReplaceTypeGraph #621

Merged
merged 7 commits into from
Mar 11, 2021
Merged

$SetReplaceTypeGraph #621

merged 7 commits into from
Mar 11, 2021

Conversation

maxitg
Copy link
Owner

@maxitg maxitg commented Mar 4, 2021

Changes

  • Adds a $SetReplaceTypeGraph constant.
  • The constant contains the nicely formatted type graph.

Examples

  • Examples below do not work directly because they use fake types. To try them out, do something like

    AppendTo[$ContextPath, "SetReplace`PackageScope`"];

    and then evaluate the definitions (line 15 to 81) from typeSystem.wlt.

  • Now, check $SetReplaceTypeGraph:

    In[] := $SetReplaceTypeGraph
    image

This change is Reviewable

@maxitg maxitg added feature New functionality, or change in existing functionality wolfram language Requires Wolfram Language implementation labels Mar 4, 2021
@maxitg maxitg added this to the Project Yellowstone milestone Mar 4, 2021
@maxitg maxitg requested review from taliesinb and daneelsan March 4, 2021 19:05
@maxitg maxitg self-assigned this Mar 4, 2021
@maxitg maxitg marked this pull request as draft March 4, 2021 19:06
Base automatically changed from feature/SetReplaceObjectType to master March 7, 2021 11:16
@maxitg maxitg force-pushed the feature/SetReplaceTypeGraph branch from ff7c456 to d13be17 Compare March 9, 2021 00:52
@maxitg
Copy link
Owner Author

maxitg commented Mar 9, 2021

I'm just going to add a table of contents to the type system README, and then this will be ready for review.

@maxitg maxitg marked this pull request as ready for review March 9, 2021 17:00
@maxitg
Copy link
Owner Author

maxitg commented Mar 9, 2021

@taliesinb, @daneelsan, this is ready for review now.

Copy link
Collaborator

@daneelsan daneelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @maxitg and @taliesinb)


Documentation/SymbolsAndFunctions/TypeSystem/$SetReplaceTypeGraph.md, line 13 at r2 (raw file):

```

Not a very informative image hehe. Was this intended because we have yet to define some types?

image.png

Copy link
Owner Author

@maxitg maxitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @daneelsan and @taliesinb)


Documentation/SymbolsAndFunctions/TypeSystem/$SetReplaceTypeGraph.md, line 13 at r2 (raw file):

Previously, daneelsan (Daniel Sanchez) wrote…

Not a very informative image hehe. Was this intended because we have yet to define some types?

image.png

Yes, that's very much intended. We need to add some types to it (in another PR).

Copy link
Collaborator

@daneelsan daneelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @daneelsan and @taliesinb)

@maxitg maxitg merged commit 5707163 into master Mar 11, 2021
@maxitg maxitg deleted the feature/SetReplaceTypeGraph branch March 11, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality, or change in existing functionality wolfram language Requires Wolfram Language implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants