Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 0.4.6 breaks memcached integration #665

Closed
jGleitz opened this issue Nov 22, 2023 · 1 comment · Fixed by #682
Closed

[BUG] 0.4.6 breaks memcached integration #665

jGleitz opened this issue Nov 22, 2023 · 1 comment · Fixed by #682
Labels

Comments

@jGleitz
Copy link
Contributor

jGleitz commented Nov 22, 2023

Upgrading from 0.4.5 to 0.4.6 breaks configurations that set up memcached for mailman-web like so:

CACHES = {
    'default': {
        'BACKEND': 'django.core.cache.backends.memcached.MemcachedCache',
        'LOCATION': os.environ.get('MEMCACHED_HOST', 'memcached') + ':11211',
    }
}

The reason seems to be that the python-memcached integration was dropped with django 3.2 (it’s documented for 3.1, but not for 3.2). django-mailman3 1.3.11 requires at least django 3.2.

To fix this, the image should install either pylibmc or pymemcache instead of python-memcached. Users can then switch to the corresponding django backend.

@jGleitz jGleitz added the bug label Nov 22, 2023
@jGleitz
Copy link
Contributor Author

jGleitz commented Nov 22, 2023

I took this opportunity to remove memcached caching from my setup entirely since it doesn’t really seem to be necessary since #463 was closed.

So personally, I would be fine with removing python-memcached from the container without replacement. I don’t know how many other users are relying on it, though.

maxking added a commit that referenced this issue Jan 24, 2024
maxking added a commit that referenced this issue Jan 24, 2024
* Repalce python-memcached with pylibmc

Fixes #665

* Replace 2nd instance of python-memcached.

* Use pure python implementation in pymemcache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant