Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postorius fixes #438

Merged
merged 7 commits into from
Feb 28, 2021
Merged

Postorius fixes #438

merged 7 commits into from
Feb 28, 2021

Conversation

danil-smirnov
Copy link
Contributor

Hey @maxking

This PR is for making Postorius-only deployment better by disabling non-existent Hyperkitty archiver (and avoiding its representation as "Active" in "Settings - Archiving" menu of a list).

Also, I've found postorius settings.py file quite outdated in comparison with the one of web image. I've migrated to it everything which seemed reasonable to me.

However, I wonder should we migrate django-compressor part as well or it's Hyperkitty-specific?

Copy link
Owner

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this. Postorius’ image unfortunately is neglected more than other images. But it is great to have it up-to-date and have core image support Postorius’s image in a more first class way.

I have just a minor comment, but rest looks good.

postorius/mailman-web/settings.py Outdated Show resolved Hide resolved
@danil-smirnov
Copy link
Contributor Author

I see @maxking but what about django-compressor part? I suspect it might be useful for postorius image as well...

@maxking
Copy link
Owner

maxking commented Feb 28, 2021

but what about django-compressor part? I suspect it might be useful for postorius image as well.

Postorius doesn't depend on django-compressor, not yet atleast.

@danil-smirnov
Copy link
Contributor Author

Thanks @maxking , I've also opened #439 to keep both settings.py in the same state for better maintainability.

@maxking
Copy link
Owner

maxking commented Feb 28, 2021

Thanks, lgtm!

@maxking maxking enabled auto-merge (squash) February 28, 2021 18:32
@maxking maxking merged commit 06ed617 into maxking:master Feb 28, 2021
@danil-smirnov danil-smirnov deleted the postorius-fixes branch February 28, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants