[web, postorius] Fix libldap installation package group #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks for your PR! Can you please also make the same changes in Dockerfile.dev files too? There are 2 more of those, one each for web and postorius |
The libldap package is not installed in the mailman-web:0.5 and postorius images despite being listed as a dependency in the Dockerfile. This issue arises because libldap is included in the .build-deps virtual package group, which is removed at the end of the build process, causing the package to be uninstalled. This commit addresses the issue by moving libldap from the .build-deps virtual package group to the .mailman-rundeps virtual package group in both the web and postorius Dockerfiles. This ensures that libldap remains installed in the final image, as it is now part of the runtime dependencies. Changes: - Move libldap installation from .build-deps to .mailman-rundeps in postorius/Dockerfile and postorius/Dockerfile.env; - Move libldap installation from .build-deps to .mailman-rundeps in web/Dockerfile and web/Dockerfile.env. These changes are necessary to ensure that the libldap package is available in the running containers, preventing runtime errors related to missing LDAP dependencies. Signed-off-by: Antonio Rocco <8lue@8lue.xyz>
8Iue
force-pushed
the
move-libldap-installation-to-mailman-rundeps
branch
from
59ebe3b
to
1d883a7
Compare
|
@maxking good point - For a cleaner commit history, I've amended the previous commit to also include the changes in the |
|
Thanks @8Iue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The libldap package is not installed in the
mailman-web:0.5andpostoriusimages despite being listed as a dependency in theDockerfile. This issue arises becauselibldapis included in the.build-depsvirtual package group, which is removed at the end of the build process, causing the package to be uninstalled.This commit addresses the issue by moving
libldapfrom the.build-depsvirtual package group to the.mailman-rundepsvirtual package group in both thewebandpostorius-Dockerfiles. This ensures thatlibldapremains installed in the final image, as it is now part of the runtime dependencies.Changes:
libldapinstallation from.build-depsto.mailman-rundepsinpostorius/Dockerfile;libldapinstallation from.build-depsto.mailman-rundepsinweb/Dockerfile.These changes are necessary to ensure that the
libldappackage is available in the running containers, preventing runtime errors related to missing LDAP dependencies.Comments
Closes #703