build: cmake: remove lib prefix on Windows #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
previously approved these changes
Apr 27, 2021
oschwald
approved these changes
Apr 27, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_SHARED_LIBRARY_PREFIXdefaults tolibon UNIX systems but to an empty string on Windows which follows the conventions on these systems. The existing build forces the prefix on all platforms so the dynamic library produced by this setup on Windows will belibmaxminddb.dll(instead ofmaxminddb.dll).This patch just removes the explicit configuration of the prefix so the dynamic library on Linux will be
libmaxminddb.soandmaxminddb.dllon Windows.I'm not sure if this hard-coded prefix was intentional. I'm working on Conan package for libmaxmminddb and I have to include this patch to make linking work on Windows. It could be something specific to Conan though but I think the change makes sense.