build: cmake: export all symbols on Windows #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build libmaxminddb as a dynamic library on Windows, the
.libfile is not created as the symbols in the library are not annotated with__declspec(dllimport). This can be workaround withWINDOWS_EXPORT_ALL_SYMBOLSCMake property.Easiest workaround is to configure with
cmake -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON.This patch enables the above property on the
maxminddbtarget only which seems to be a cleaner solution.