Lowercase Windows includes in order to build with MinGW on GNU/Linux #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
oschwald
added a commit
that referenced
this pull request
Dec 1, 2014
Lowercase Windows includes in order to build with MinGW on GNU/Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GNU/Linux filesystems are generally case-sensitive, trying to cross-compile libmaxminddb with MinGW for Windows fails since the include files can't be found because their names are lowercase.
This doesn't change anything with building it on Windows since Windows filesystems are case-insensitive, so the includes are found in both case.