Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geoip2 version #278

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

nealzhu3
Copy link
Contributor

geoip2 version 4.1.0 introduced new ConnectionType enum value "Satellite". https://github.com/maxmind/GeoIP2-java/blob/204a979c2759632a465519c4e459261f01a3f9b8/src/main/java/com/maxmind/geoip2/model/ConnectionTypeResponse.java#L60
We can't deserialize maxmind response because mindfruad is using the old version of geoip2 which doesn't have the "Satellite" enum value.

@ugexe
Copy link
Contributor

ugexe commented Oct 27, 2023

Are you getting an exception or is the value just not available?

@nealzhu3
Copy link
Contributor Author

Are you getting an exception or is the value just not available?

I got an exception.
com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `com.maxmind.geoip2.model.ConnectionTypeResponse$ConnectionType` from String "Satellite": not one of the values accepted for Enum class: [Cellular, Cable/DSL, Corporate, Dialup] at [Source: (org.apache.http.conn.EofSensorInputStream); line: 1, column: 1471] (through reference chain: com.maxmind.minfraud.response.InsightsResponse["ip_address"]->com.maxmind.minfraud.response.IpAddress["traits"]->com.maxmind.geoip2.record.Traits["connection_type"])

@oschwald
Copy link
Member

I apologize for the trouble. I made this PR against geoip2 that should help prevent this sort of issue in the future.

@oschwald oschwald merged commit f48d6b4 into maxmind:main Oct 27, 2023
17 checks passed
@nealzhu3 nealzhu3 deleted the update-geoip2-version branch October 27, 2023 19:30
@nealzhu3
Copy link
Contributor Author

nealzhu3 commented Oct 27, 2023

I apologize for the trouble. I made this PR against geoip2 that should help prevent this sort of issue in the future.

Can you release the latest version to maven? I would like to use the latest version.

oschwald added a commit that referenced this pull request Oct 27, 2023
@oschwald
Copy link
Member

Yep, we will release shortly. Thanks!

oschwald added a commit that referenced this pull request Oct 27, 2023
oschwald added a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants