Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small performance improvements #553

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

Iliano101
Copy link
Contributor

Hey there,
I made a few changes that improve the performance, mainly in the HomeScreen.
Here is the list :

  • Added a ProGuard rule to remove all logs from the release build. The Log.w and Log.e are not removed by default by the compiler.
  • Added @immutable to some classes. This has the effect of telling Android Compose that these classes don't need to be recomposed as often, improving performance.
  • Added a Key to all items enumeration in the HomeScreen. This also has the effect of telling Android Compose that the items only need to be recomposed if they are different.

In total, this improves the performance in the HomeScreen and in the app as a whole. There is still some lag, but it is smaller.

@maxrave-dev
Copy link
Owner

Can you fix conflict with my branch

@Iliano101
Copy link
Contributor Author

Alright, it won't be long

@Iliano101
Copy link
Contributor Author

@maxrave-dev
Done

@Iliano101
Copy link
Contributor Author

@maxrave-dev
Done

@maxrave-dev
Copy link
Owner

@CodiumAI-Agent /improve

@CodiumAI-Agent
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@maxrave-dev maxrave-dev merged commit b0a0ce4 into maxrave-dev:jetpack_compose Nov 28, 2024
@maxrave-dev
Copy link
Owner

@Iliano101 Thanks for contribute <3

@CodiumAI-Agent
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@Iliano101 Iliano101 deleted the performance branch November 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants