Improvements and bug fixes for 1.5.0 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…position
corrected various state changes, to ensure they are set before and after animations (in Animated.timing().start() callback, not the other way around)
fixed state.isAnimateBackdrop to always be true on animation start, false on end
ported hardwareAccelerated={true} back from maxs15#196 that was lost in the shuffle of merging for 1.5.0
|
Hi @maxs15. Any interest in merging this PR? I'm getting the same close animation issue on my project. Thanks! |
|
Awesome thanks @fungilation ! |
|
I encounter the same issue. No animation when swipe close the modal and the upper right x icon is not shown too. May i ask if there is any fix? Thanks a lot |
maxs15
added a commit
that referenced
this pull request
Oct 4, 2020
Improvements and bug fixes for 1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.5.0, closing modal (by whichever way) no longer gets animated (did in prior version, as it should be). My state change corrections fixed this (below), as tested and in use in my own app WonderSwipe (iOS and Android). Fixes #226 #225