[DE249] Destroying all snapshot of rebuild clone dataset once rebuild completes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… completes
- Changes in `zfs stats` output.
...
isIOAckSenderCreated: 1
isIOReceiverCreated: 1
...
Earlier it was :
...
isIOAckSenderCreated: -1
isIOReceiverCreated: -1
...
Signed-off-by: mayank <mayank.patel@cloudbyte.com>
pawanpraka1
reviewed
Feb 13, 2019
| char snapname[MAXNAMELEN]; | ||
| objset_t *os = zv->zv_objset; | ||
| uint64_t obj = 0, cookie = 0; | ||
|
|
added 2 commits
February 13, 2019 19:52
Signed-off-by: mayank <mayank.patel@cloudbyte.com>
Codecov Report
@@ Coverage Diff @@
## zfs-0.7-release #199 +/- ##
===================================================
+ Coverage 52.74% 52.77% +0.02%
===================================================
Files 240 240
Lines 78218 78201 -17
===================================================
+ Hits 41258 41268 +10
+ Misses 36960 36933 -27Continue to review full report at Codecov.
|
vishnuitta
reviewed
Feb 14, 2019
| break; | ||
| } | ||
|
|
||
| if (!(strcmp(snapname, REBUILD_SNAPSHOT_SNAPNAME) == 0) && |
There was a problem hiding this comment.
can we use internal_snapshot() here?
There was a problem hiding this comment.
internal_snapshot is from libzrepl. So, we cannot use it here unless we link libzpool with libzrepl.
vishnuitta
reviewed
Feb 14, 2019
| * on a dataset | ||
| */ | ||
| int | ||
| uzfs_destroy_internal_all_snap(zvol_state_t *zv) |
There was a problem hiding this comment.
name change to 'uzfs_destroy_all_internal_snapshots'?
vishnuitta
reviewed
Feb 14, 2019
|
This need to be cherry-picked as well @mynktl |
mynktl
added a commit
to mynktl/cstor
that referenced
this pull request
Feb 19, 2019
… dataset once rebuild completes (mayadata-io#199) Two changes in the `zfs stats` output format Signed-off-by: mayank <mayank.patel@cloudbyte.com>
vishnuitta
pushed a commit
that referenced
this pull request
Feb 19, 2019
* [DE249]fix(zrepl): destroying all internal snapshots of rebuild clone dataset once rebuild completes (#199) * [TC57] fix(stale clone): delete stale volume in timer fn and its test cases (#200) * fix(memleak): freeing string in error case in uzfs_zinfo_destroy_stale_clone (#201) Signed-off-by: mayank <mayank.patel@cloudbyte.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
[DE249] Destroying all snapshot of rebuild clone dataset once rebuild completes
Changes in
zfs statsoutput....
isIOAckSenderCreated: 1
isIOReceiverCreated: 1
...
Earlier it was :
...
isIOAckSenderCreated: -1
isIOReceiverCreated: -1
...
Signed-off-by: mayank mayank.patel@cloudbyte.com