Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-factor authentication #1817

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Multi-factor authentication #1817

merged 6 commits into from
Feb 6, 2025

Conversation

Shpigford
Copy link
Member

@Shpigford Shpigford commented Feb 6, 2025 •
edited
Loading

Implements #1372

CleanShot.2025-02-06.at.11.56.59.mp4

@Shpigford Shpigford requested a review from zachgoll February 6, 2025 18:05
zachgoll
zachgoll reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great!

From a security standpoint, we should probably protect the password_resets_controller with 2FA if the user has it enabled. Other than that, I think the flow looks good.

app/models/user.rb Outdated Show resolved Hide resolved
test/controllers/sessions_controller_test.rb Outdated Show resolved Hide resolved
test/controllers/sessions_controller_test.rb Outdated Show resolved Hide resolved
app/controllers/mfa_controller.rb Outdated Show resolved Hide resolved
Shpigford and others added 2 commits February 6, 2025 14:09
@Shpigford @zachgoll
Update app/models/user.rb
fba40de 
Co-authored-by: Zach Gollwitzer <zach@maybe.co>
Signed-off-by: Josh Pigford <josh@joshpigford.com>
@Shpigford
Refactor MFA verification and session handling in tests
61028c0
@Shpigford Shpigford merged commit 842e376 into main Feb 6, 2025
5 checks passed
@Shpigford Shpigford deleted the mfa branch February 6, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shpigford @zachgoll