Add icon to share weather information across app #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayokunadeniyi
requested changes
Dec 6, 2020
| @@ -316,4 +342,14 @@ class HomeFragment : BaseFragment() { | |||
| ExistingPeriodicWorkPolicy.REPLACE, weatherUpdateRequest | |||
| ) | |||
| } | |||
|
|
|||
| private fun shareWeatherInformation(WeatherInformation:String){ | |||
There was a problem hiding this comment.
Hi, @ELTEGANI, thanks for this! Just a little change, could we get the parameter WeatherInformation to start with a small letter weatherInformation?
mayokunadeniyi
approved these changes
Dec 6, 2020
|
Alright, we're good to go! Thank you @ELTEGANI 👍 |
mayokunadeniyi
changed the title
Sir @mayokunthefirst appreciated the effort to let us collaborate in this awesome app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an icon to share weather information across apps. @mayokunthefirst