Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

local storage: implement single-node deletion #426

Merged
merged 1 commit into from
Feb 5, 2023
Merged

local storage: implement single-node deletion #426

merged 1 commit into from
Feb 5, 2023

Conversation

SergNikitin
Copy link
Collaborator

@SergNikitin SergNikitin commented Feb 3, 2023 •
edited
Loading

@SergNikitin SergNikitin mentioned this pull request Feb 3, 2023
Closed
8 tasks
@SergNikitin
Copy link
Collaborator Author

In contrast to deletion of nodes from datacenter storage, this actually deletes the node - not just marks it as deleted = 1. I think trying to mimic what smuggler does will be truly hellish without SQL, so I'm thinking we should go with the more simplistic approach.

@SergNikitin SergNikitin marked this pull request as ready for review February 3, 2023 13:52
@akindyakov
Copy link
Contributor

I'm thinking we should go with the more simplistic approach.

Yes, I agree. We need to move fast on this, will do it later

@SergNikitin SergNikitin merged commit afabe8d into main Feb 5, 2023
@SergNikitin SergNikitin deleted the storage-api-bugfix-node-delete branch February 5, 2023 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akindyakov akindyakov akindyakov approved these changes

Assignees
No one assigned
Labels
archaeologist effort [XXXS] Less than 1 hour fix impact [XXS]
Projects
None yet
Milestone
Archaeologist Release v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SergNikitin @akindyakov