Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Use plain unix time (number) for NodeCreateArgs #427

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Use plain unix time (number) for NodeCreateArgs #427

merged 3 commits into from
Feb 5, 2023

Conversation

akindyakov
Copy link
Contributor

@akindyakov akindyakov commented Feb 5, 2023 •
edited
Loading

Use plain unix time (number) for NodeCreateArgs instead of Date to make it trivially convertible to JSON and back. Otherwise we are loosing it when in Truthsayer → Archaeologist connection, when saving nodes with known creation date.

@akindyakov akindyakov marked this pull request as ready for review February 5, 2023 08:40
@akindyakov akindyakov added bug Something isn't working fix archaeologist labels Feb 5, 2023
@akindyakov akindyakov mentioned this pull request Feb 5, 2023
Merged
@akindyakov akindyakov merged commit d727ab1 into main Feb 5, 2023
@akindyakov akindyakov deleted the created-at-unixtime branch February 5, 2023 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SergNikitin SergNikitin SergNikitin approved these changes

Assignees
No one assigned
Labels
archaeologist bug Something isn't working fix
Projects
None yet
Milestone
Archaeologist Release v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akindyakov @SergNikitin