This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Prevent yielding duplicated nodes from iterator #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem of duplicates from node iterator comes from the fact that iterator is used as part of state being mutable object - every call to
next()
changes index in it. And in current version of SearchGrid iterator in state is never set explicitly, this is where most of the problems originates.But there are more, another issue is that fetching callback can be called not exclusively. Meaning that there were multiple calls to it at the same time, which results in data race. I tried to solve this with
throttling
, but that didn't work very well. So I used a proper mutex now, fromasync-mutext
package. Works like a charm.Uploading Screen Recording 2023-02-12 at 16.53.19.mov…
Fixes #428
#351