-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text gets invisible while running mocha #59
Comments
I fixed this in a gist of mine (I should launch a PRQ for this :) ) -> https://gist.github.com/kevin-smets/8568070#file-solarized-dark-fixed-itermcolors The link fixes this: by default, the Ansi 8 Color is not readable on the set background for Solarized dark. This value has been replaced by the one from the Solarized high contrast theme. |
👍Please do! |
@kevin-smets Awesome. But shouldn't it be any base colour rather than blue? Maybe |
@umayr good point, but that way it does not look like a highlight at all? It looks just like regular output. Just thought high contrast would be the nicest / closest match. Though the rest of the colors are indeed more grey like in Solarized Dark. But in the high contrast version, the highlight versions match the base colors more closely... @mbadolato what do you think? |
Either works for me; no particular preference. I may be one of the few people that doesn't use Solarized Dark 😉 |
That looks really awesome. Thank you, @kevin-smets. |
No problem, now I can simplify my gist :D 👯 |
The issue was reverted (see #62). So other than changing the color manually yourself, or using a tweaked theme (or different altogether), this issue is likely to stay, if you're using something that has output in the affected color. AFAIK, the Solarized theme in here matches the official standard, so it's not something with the theme itself, but rather with the output of the program |
As seen in the screenshot, some part of the text gets invisible for Solarized Dark theme. It's happening with gulp too.
My iTerm version is
2.1.4
.The text was updated successfully, but these errors were encountered: