Stop installing typing on Python 3.5+ #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, have this fixed already on other similar projects. Thanks for the PR! |
si14
added a commit
to MELScience/google-measurement-protocol
that referenced
this pull request
Sep 3, 2020
It breaks pip, see mbarkhau/bumpver#148
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing https://pypi.org/project/typing/ is not needed on Python 3.5+. Additionally, a bug in pip means that having
typingfrom PyPI breaks some commands on Python 3.7 and 3.8. Our only dependency that installed typing inconditionally is pycalver, so this pull request fixes the issue.Thanks!