Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding decontamination and a few other misc stuff #26

Merged
merged 69 commits into from
May 16, 2022

Conversation

leoisl
Copy link
Collaborator

@leoisl leoisl commented May 13, 2022

This PR is mainly to add decontamination, but there were a few other stuff added/fixed in it, which will be described here:

  1. Decontamination of NTMs and human added. The decontamination DB is composed of the metadata, which is included in this repo in data/decontamination_db/remove_contam.tsv.gz, and the index, which is downloaded externally due to being 5.1GB. An error is shown if the decontamination DB is not present, with an EBI FTP URL from where to download it and where to put it. Several steps were added to tbpore pipeline to deal with decontamination;
  2. A snakemake pipeline that runs tbpore on 91 samples and compare the consensus, BCFs and mykrobe output against H2H results added. This pipeline was initially private, but as I was using it frequently, and we will keep using it in the future, I think it is good to add it to the repo;
  3. minimap2 downgraded to 2.22 to replicate H2H results;
  4. Now also outputting the exact command line a tool was run to the error log file to make debugging easier;
  5. mykrobe is now called on the decontaminated subsampled reads, instead of the raw ONT reads;

Closes #24 #23 #21 #16

leoisl and others added 30 commits April 27, 2022 10:53
@leoisl
Copy link
Collaborator Author

leoisl commented May 13, 2022

Code coverage decreased by 0.56% but I can confirm is nothing to worry about!

@leoisl leoisl merged commit aff3098 into mbhall88:main May 16, 2022
@leoisl leoisl deleted the decontamination branch May 17, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimap2 index URL
2 participants