-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding decontamination and a few other misc stuff #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get identical results as those of H2H
and mocking it in tests
Code coverage decreased by 0.56% but I can confirm is nothing to worry about! |
mbhall88
approved these changes
May 16, 2022
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly to add decontamination, but there were a few other stuff added/fixed in it, which will be described here:
data/decontamination_db/remove_contam.tsv.gz
, and the index, which is downloaded externally due to being 5.1GB. An error is shown if the decontamination DB is not present, with an EBI FTP URL from where to download it and where to put it. Several steps were added totbpore
pipeline to deal with decontamination;snakemake
pipeline that runstbpore
on 91 samples and compare the consensus,BCF
s andmykrobe
output againstH2H
results added. This pipeline was initially private, but as I was using it frequently, and we will keep using it in the future, I think it is good to add it to the repo;minimap2
downgraded to2.22
to replicateH2H
results;mykrobe
is now called on the decontaminated subsampled reads, instead of the raw ONT reads;Closes #24 #23 #21 #16