Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support for magic #7

Closed
wants to merge 5 commits into from
Closed

Conversation

epicfaace
Copy link

In Windows, magic must be initialized with the kwarg magic_file that gives the path of the .magic file. This PR:

  • Allows for Windows support by allowing the .magic file to be specified by the MAGIC_FILE_PATH setting in settings.py.
  • Further documentation in the README to describe how to set this up on Windows.

(Similar PR on original repository here: kaleidos#13)

@mbourqui
Copy link
Owner

mbourqui commented Dec 24, 2017

Thank you for your interest in this project (the original one and my fork)!
Since my fork differs in structure from the original repo, your PR conflicted with this repo. I had to manually replicate your changes, but it's all merged.
I also pushed a new release on PyPi, so you can benefit from your changes as of now :)

@mbourqui mbourqui closed this Dec 24, 2017
@epicfaace
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants