Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations for graphical editor support #21

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Conversation

mbrea-c
Copy link
Owner

@mbrea-c mbrea-c commented Jan 27, 2024

The development of the visual editor needs a number of changes in the library, which has resulted in breaking changes.
Key changes:

  • Serialized format of animation graphs changed, to simplify the serialization code (for saving edited graphs back to disks). Existing graphs will need to be adapted by hand.
  • Extended AnimationGraph API with node positions data (in Extra), validation, node renaming and node removal.
  • Updated node icons to work with egui default font.
  • Fixed reflection support for a variety of types.

This PR is already massive so further changes will be left for further PR:

  • Order-preserving maps for node inputs/output specs, and graph inputs/outputs. Without this, order is unstable as values are mutated in the editor.
  • Graph evaluation should not panic when missing connections, as it crashes the editor when the preview is enabled. Tracking issue: Error handling during graph evaluation #22.

@mbrea-c mbrea-c added the enhancement New feature or request label Jan 27, 2024
@mbrea-c mbrea-c marked this pull request as ready for review January 28, 2024 22:02
@mbrea-c mbrea-c merged commit e28003f into master Jan 28, 2024
4 checks passed
@mbrea-c mbrea-c deleted the editor-preparation branch June 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant