feat: switch to OIDC library that's actually released #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That failing test smells like a GTFS change issue unrelated to this PR. I can check that out. |
|
#1372 should fix that test case. |
arkadyan
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Thanks, this is great. It took me a minute to spot the extra "c" and understand what I was looking at—I hadn't come across this library before. This is very timely as I'm just today adding SSO support to our new project, so I will shift direction and use this library.
| elixir 1.14.5-otp-25 | ||
| erlang 25.3.2.7 | ||
| elixir 1.14.5-otp-26 | ||
| erlang 26.1.2 |
|
It's a fairly new library, but I wanted something that 1) supported log out fairly natively 2) was in Hex and ended up with Oidcc (even OpenID certified!) and the UeberauthOidcc wrapper around it. |
|
Ugh, the data changed again. I have a new fix. |
|
Rebasing this branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the test failures are only in
alerts_processorand are also happening onmain.