-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(TripPlannerForm): use LiveComponent #2173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
force-pushed
the
cbj/trip-planner-input-form
branch
from
September 18, 2024 17:42
d10f842
to
6c4eaf1
Compare
thecristen
force-pushed
the
cbj/trip-planner-input-form
branch
from
September 18, 2024 18:21
6c4eaf1
to
31a17da
Compare
anthonyshull
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: LiveView-compatible trip planner form inputs
This is primarily a refactor of the trip planner form, from using a functional component to a
Phoenix.LiveComponent
.Highlights:
Other changes:
MbtaMetro
, so this PR installs and sets this up as well.MbtaMetro
blocklist
since they conflict with our existing Bootstrap styles in terrible waysimportant: true
CoreComponents
~p
in a test