refactor(docker): Unify dev Dockerfiles #2185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The current state of the world is that the two dev instances of dotcom have different dockerfiles, which means that during a
docker compose build
, they get built twice. Since the only meaningful difference between the dockerfiles was the--sname
variable, I figured that that could be an env variable instead.By unifying the dockerfiles, we get two benefits:
docker compose build
, since it'll only build once./1/Dockerfile
and/2/Dockerfile
.General checks
New UI, or substantial UI changes
New endpoints, or non-trivial changes to current endpoints