Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): Unify dev Dockerfiles #2185

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Oct 4, 2024

Summary of changes

The current state of the world is that the two dev instances of dotcom have different dockerfiles, which means that during a docker compose build, they get built twice. Since the only meaningful difference between the dockerfiles was the --sname variable, I figured that that could be an env variable instead.

By unifying the dockerfiles, we get two benefits:

  • Faster docker compose build, since it'll only build once.
  • No drift between /1/Dockerfile and /2/Dockerfile.

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessss this occurred to me earlier this week and you just did it ha

@joshlarson
Copy link
Contributor Author

@thecristen It helps to not be expected to do trip planner work yet! 😅

@joshlarson joshlarson merged commit 10dc083 into main Oct 4, 2024
26 checks passed
@joshlarson joshlarson deleted the jdl/unify-dev-dockerfiles branch October 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants