feat(docker): Allow dotcom-1 and dotcom-2 start in parallel in docker compose #2188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup has
dotcom-2
wait fordotcom-1
to finish starting up before it even starts trying. This PR speeds updocker compose
startup time, since it doesn't forcedotcom-2
to wait anymore.Before
After
Historical context
elixir ... mix phx.server
processes from stepping on each other. That's because they were both (under the hood) runningmix deps.compile
and writing to the same_build
directory, which was mounted in by docker-compose.docker-compose
'ed containers #2182,dotcom-1
anddotcom-2
aren't sharing the same_build
directory anymore, andmix deps.compile
is run as part of building the image, which means it doesn't happen again when the containers are starting up, so chaining is no longer necessary.