Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore cache calls in LocationService, fixing some warnings #2190

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

joshlarson
Copy link
Contributor

This removes these warnings, which show up any time we run any test

     warning: module attribute @ttl was set but never used10@ttl :timer.hours(24)~~~~~~~~~~~~~~~~~~~~~
     │
     └─ lib/location_service/location_service.ex:10: LocationService (module)

     warning: module attribute @cache was set but never used9@cache Application.compile_env!(:dotcom, :cache)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ lib/location_service/location_service.ex:9: LocationService (module)

@joshlarson joshlarson requested a review from a team as a code owner October 7, 2024 14:07
@joshlarson joshlarson enabled auto-merge (squash) October 7, 2024 14:56
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓 This was my sloppiness, I'd changed the format of the responses here and commented these out to disable the caching here, but had always meant to reenable these once the TTL window had passed (thus old responses no longer cached).

@joshlarson Can you please put these back and un-comment the @decorate cacheable calls? That'll remove the warnings by resuming usage of those attributes 😇

@joshlarson
Copy link
Contributor Author

Can you please put these back and un-comment the @decorate cacheable calls?

@thecristen Finally did ☝️! I think this should be ready for re-review now!

@joshlarson joshlarson changed the title fix: Remove unused attributes from LocationService, fixing some warnings fix: Restore cache calls in LocationService, fixing some warnings Oct 22, 2024
@joshlarson joshlarson enabled auto-merge (squash) October 22, 2024 15:48
@joshlarson joshlarson merged commit 6f4a84f into main Oct 22, 2024
23 checks passed
@joshlarson joshlarson deleted the jdl/remove-unused-attributes branch October 22, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants