feat(LiveComponents.TripPlannerForm): fixes for mode selector + updated MbtaMetro & overhauled typography #2194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: TP UI | Inputs | Polished accessibility selector and TP UI | Inputs | Polished mode selector
Technically not 100% polished yet since these don't yet use the official design system tokens for colors and spacing. These are pretty close.
Sorry for the omnibus PR! 😅 But the recent updates to
MbtaMetro
included CSS I wanted to incorporate here, including:These let me start phasing out a whole bunch of our homegrown utility files... which accounts for most of this PR diff. This phaseout is not even close to complete but is enough for now. I've checked many pages to ensure I'm not introducing style regressions!
@tailwindcss/forms
plugin in full, including its style resets. This required some edits to our custom<select>
styling to avoid showing multiple carets.important: true
as the forms plugin is kinda buggy otherwise, since it inserts its reset CSS in a way that overwrites our own styles. 🙄<details>
open state changing inside a LiveView.