Show the ad for the mobile app to everyone not on an android #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
changed the title
thecristen
previously requested changes
Oct 24, 2024
joshlarson
reviewed
Oct 25, 2024
| @@ -103,7 +103,7 @@ defmodule DotCom.Mixfile do | |||
| {:jason, "1.4.4", override: true}, | |||
| {:logster, "1.1.1"}, | |||
| {:mail, "0.3.1"}, | |||
| {:mbta_metro, "0.0.49"}, | |||
| {:mbta_metro, "0.0.50"}, | |||
There was a problem hiding this comment.
Was upgrading metro necessary as part of this PR?
There was a problem hiding this comment.
No, but we might as well.
There was a problem hiding this comment.
I won't block approval on this, but in general I don't like lumping library upgrades together with unrelated features. It runs the risk of creating hard-to-revert surprises, especially when the library is in alpha, as metro is.
joshlarson
reviewed
Oct 25, 2024
joshlarson
requested changes
Oct 25, 2024
There was a problem hiding this comment.
- https://github.com/mbta/dotcom/pull/2203/files#r1817198719 <-- I think we need to suppress the banner on ferry pages too, per the A/C's of the ticket.
- I also think that the logic in
mobile-app-banner.jsis getting complicated enough, especially with all the regexes, that it would be worth adding tests. This can be a follow-up, but unless that logic gets a lot simpler (for instance, I don't really understand why we're not just showing it on every page), I'd hesitate to iterate on it anymore without tests.
joshlarson
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/555089885850811/1208568379309256/f
I didn't put it on the schedule finder because it is a modal, not a page. It is on the schedule page below the schedule finder.