Switch away from using npm for metro #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
force-pushed
the
ags/use-non-npm-metro
branch
from
e65eb0c
to
3ed7b4a
Compare
anthonyshull
force-pushed
the
ags/use-non-npm-metro
branch
from
fccb549
to
a4334d7
Compare
anthonyshull
force-pushed
the
ags/use-non-npm-metro
branch
from
cee7a9d
to
420ab72
Compare
anthonyshull
commented
Nov 5, 2024
| @@ -58,4 +58,6 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| git config --global url."https://github.com/".insteadOf ssh://git@github.com/ | |||
| npm install -g husky@latest | |||
There was a problem hiding this comment.
📓 This is necessary to run the command below.
anthonyshull
commented
Nov 5, 2024
| @@ -58,4 +58,6 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| git config --global url."https://github.com/".insteadOf ssh://git@github.com/ | |||
| npm install -g husky@latest | |||
| npm install --prefix assets --package-lock-only | |||
There was a problem hiding this comment.
📓 This is necessary for install to pick up mbta_metro as a path.
anthonyshull
commented
Nov 5, 2024
| @@ -101,6 +101,7 @@ jobs: | |||
| priv | |||
| react_renderer/dist/app.js | |||
| key: ci-application-cache-${{ github.sha }} | |||
| - run: npm install --prefix assets -S -install-links deps/mbta_metro/priv/ | |||
There was a problem hiding this comment.
📓 This is necessary to install mbta_metro from a path, but getting its deps and putting them in node_modules.
anthonyshull
commented
Nov 5, 2024
Comment on lines
+40
to
+47
| RUN npm i -g husky@latest | ||
|
|
||
| WORKDIR /root/assets | ||
|
|
||
| RUN npm install --package-lock-only | ||
| RUN npm ci --ignore-scripts | ||
| RUN npm install -S -install-links ../deps/mbta_metro/priv/ | ||
|
|
There was a problem hiding this comment.
📓 This just does all three of those things in the build process.
There was a problem hiding this comment.
cool. we should probably create an alias to group these commands at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have an organizational npm account so it will probably be easier and faster in the short-term to not publish metro's JS via npm. That means dotcom has to make some changes to accommodate.