Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package-lock to reflect metro deps #2217

Merged
merged 1 commit into from
Nov 7, 2024
Merged

update package-lock to reflect metro deps #2217

merged 1 commit into from
Nov 7, 2024

Conversation

thecristen
Copy link
Collaborator

I ran npm --prefix assets install and got some updates in the package-lock.json! Does this seem legit?

@thecristen thecristen requested a review from a team as a code owner November 7, 2024 16:24
anthonyshull
anthonyshull approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@anthonyshull anthonyshull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right. I think this is a one time issue to do with changing the way that metro was included. I don't think this got flagged as necessary because the automated builds do this.

@thecristen thecristen merged commit eb086ac into main Nov 7, 2024
26 checks passed
@thecristen thecristen deleted the cbj/packagelock branch November 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshull anthonyshull anthonyshull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecristen @anthonyshull