chore: add svg img roles, improve title tags #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because these are all inlined: - they SHOULD NOT have xml preambles. apparently those belong at the start of a document and there shouldn't be more than one of these in a given page (https://stackoverflow.com/questions/38169475/svg-in-html5-when-is-xml-declaration-xml-version-1-0-encoding-utf-8#comment63771563_38172170) - xmlns/version/similar attributes on the SVG are not required
joshlarson
reviewed
Nov 15, 2024
joshlarson
reviewed
Nov 18, 2024
| <title> | ||
| green line B | ||
| </title> | ||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="24px" height="24px" role="img" viewBox="0 0 24 24"> |
There was a problem hiding this comment.
Definitely out of scope for this PR, but I would be pretty surprised if we're actually using all of icons in this folder. Maybe at some point it would be worth going through and identifying which icons we still need to keep?
There was a problem hiding this comment.
Yep. Added to the dev discussion list!
joshlarson
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: No ticket, but noticed some
<title>tags weren't a nice as they could be while using a few of these SVG files for the<.route_symbol />component. So, this PR:<title>tag content to sentence/title case.role="img"on all the SVGs, in alignment with 'Pattern 5' in this guidance: Accessible SVGs: Perfect Patterns For Screen Reader Users — Smashing MagazineAdditional optimizations because these are all inlined: