Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Simplify module attributes in SystemStatus code and tests #2366

Merged
merged 1 commit into from
Feb 7, 2025
Merged

cleanup: Simplify module attributes in SystemStatus code and tests #2366

merged 1 commit into from
Feb 7, 2025

Conversation

joshlarson
Copy link
Contributor

No ticket.

@joshlarson joshlarson requested a review from a team as a code owner February 5, 2025 18:56
thecristen
thecristen approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

lib/dotcom/system_status/alerts.ex Show resolved Hide resolved
@joshlarson joshlarson merged commit 42accb0 into main Feb 7, 2025
20 checks passed
@joshlarson joshlarson deleted the jdl/system-status/module-attributes branch February 7, 2025 18:58
anthonyshull pushed a commit that referenced this pull request Feb 10, 2025
@joshlarson @anthonyshull
cleanup: Simplify module attributes in SystemStatus code and tests (#…
7bf6227 
…2366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecristen thecristen thecristen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @thecristen