make :route_patterns a dependency of :site app #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 96.77% 96.81% +0.03%
==========================================
Files 346 346
Lines 5431 5431
==========================================
+ Hits 5256 5258 +2
+ Misses 175 173 -2 |
|
verified on dev-green |
ryan-mahoney
requested review from
phildarnowsky
and removed request for
meagonqz
phildarnowsky
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Look into schedule 500 error on dev
The application build is crashing because
:route_patternswas never added as a dependency to the:siteapplication after the modules were referenced.A similar issue happened recently with the
:servicesapplication.Assigned to: @meagonqz