wip! fix: only publish s3 assets in deploy step

mbta · Oct 29, 2024 · 22a8a17 · 22a8a17
1 parent 380d078
commit 22a8a17
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/.github/workflows/deploy-base.yml b/.github/workflows/deploy-base.yml
@@ -28,6 +28,7 @@ jobs:
       contents: read
     outputs:
       docker-tag-suffix: ${{ steps.build-push.outputs.docker-tag-suffix }}
+      docker-tag: ${{ steps.build-push.outputs.docker-tag }}
       sentry-release: ${{ steps.version-ids.outputs.sentry-release }}
     steps:
       - uses: actions/checkout@v4
@@ -41,12 +42,6 @@ jobs:
           role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
           docker-repo: ${{ secrets.DOCKER_REPO }}
           docker-additional-args: --build-arg SENTRY_RELEASE=${{steps.version-ids.outputs.sentry-release}}
-      - name: Upload static assets to S3
-        run: bash upload_assets.sh ${{ steps.build-push.outputs.docker-tag }} ${{steps.version-ids.outputs.sentry-release}}
-        env:
-          SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
-          SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
-          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
 
 
   deploy_ecs:
@@ -68,9 +63,21 @@ jobs:
           ecs-cluster: ${{ env.ECS_CLUSTER }}
           ecs-service: ${{ env.ECS_SERVICE }}
           docker-tag: ${{ secrets.DOCKER_REPO }}:${{ needs.build.outputs.docker-tag-suffix }}
+      - name: Setup AWS Credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: ${{ inputs.role-to-assume }}
+          aws-region: us-east-1
+          mask-aws-account-id: true
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+      - name: Upload static assets to S3
+        run: bash upload_assets.sh ${{ needs.build.outputs.docker-tag }} ${{steps.version-ids.outputs.sentry-release}}
+        env:
+          SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
+          SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
+          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
       - uses: getsentry/action-release@v1
         env:
           SENTRY_ORG: ${{ secrets.SENTRY_ORG }}