cleanup: Remove detour-route-selection and route-ladder-header-update…

… test groups (#2697)
mbta · Jul 24, 2024 · 656a63f · 656a63f
1 parent cf7d0ed
commit 656a63f
Show file tree

Hide file tree

Showing 12 changed files with 414 additions and 681 deletions.
diff --git a/assets/src/components/detours/diversionPage.tsx b/assets/src/components/detours/diversionPage.tsx
@@ -18,7 +18,6 @@ import { DetourFinishedPanel } from "./detourFinishedPanel"
 import { DetourRouteSelectionPanel } from "./detourRouteSelectionPanel"
 import { Route, RoutePattern } from "../../schedule"
 import RoutesContext from "../../contexts/routesContext"
-import inTestGroup, { TestGroups } from "../../userInTestGroup"
 
 const displayFieldsFromRouteAndPattern = (
   route: Route,
@@ -203,11 +202,7 @@ export const DiversionPage = ({
               routeDirection={routeDirection ?? "??"}
               detourFinished={reviewDetour !== undefined}
               onReviewDetour={reviewDetour}
-              onChangeRoute={
-                inTestGroup(TestGroups.DetourRouteSelection)
-                  ? () => send({ type: "detour.route-pattern.open" })
-                  : undefined
-              }
+              onChangeRoute={() => send({ type: "detour.route-pattern.open" })}
             />
           ) : snapshot.matches({ "Detour Drawing": "Share Detour" }) &&
             editDetour ? (

diff --git a/assets/src/components/detours/diversionPanel.tsx b/assets/src/components/detours/diversionPanel.tsx
@@ -16,7 +16,7 @@ export interface DiversionPanelProps {
   routeDirection: string
   detourFinished?: boolean
   onReviewDetour?: () => void
-  onChangeRoute?: () => void
+  onChangeRoute: () => void
 }
 
 export const DiversionPanel = ({

diff --git a/assets/src/components/routeLadder.tsx b/assets/src/components/routeLadder.tsx
@@ -1,10 +1,5 @@
 import React, { useId } from "react"
-import {
-  AlertIcon,
-  CrowdingIcon,
-  ReverseIcon,
-  ReverseIconReversed,
-} from "../helpers/icon"
+import { CrowdingIcon, ReverseIcon, ReverseIconReversed } from "../helpers/icon"
 import {
   getLadderCrowdingToggleForRoute,
   LadderCrowdingToggle,
@@ -25,7 +20,6 @@ import { LoadableTimepoints, Route, RouteId } from "../schedule.d"
 import IncomingBox from "./incomingBox"
 import Ladder from "./ladder"
 import Loading from "./loading"
-import { CloseButton as OldCloseButton } from "./closeButton"
 import Tippy from "@tippyjs/react"
 import { tagManagerEvent } from "../helpers/googleTagManager"
 import inTestGroup, { TestGroups } from "../userInTestGroup"
@@ -48,39 +42,6 @@ interface Props {
   onAddDetour?: (route: Route) => void
 }
 
-export const Header = ({
-  routeName,
-  onClose,
-  hasAlert,
-}: {
-  routeName: string
-  onClose: () => void
-  hasAlert: boolean
-}) => {
-  return (
-    <div className="c-route-ladder__header">
-      {hasAlert && (
-        <Tippy
-          content="Active detour"
-          trigger="click"
-          onShow={() => tagManagerEvent("alert_tooltip_clicked")}
-        >
-          <AlertIcon
-            className="c-route-ladder__alert-icon"
-            aria-label="Route Alert"
-          />
-        </Tippy>
-      )}
-      <div className="c-route-ladder__close-button-container">
-        <OldCloseButton closeButtonType="l_darker" onClick={onClose} />
-      </div>
-
-      <div className="c-route-ladder__route-name">{routeName}</div>
-    </div>
-  )
-}
-
-// TODO: delete old header after roll-out
 export const NewHeader = ({
   routeName,
   onClose,
@@ -130,8 +91,11 @@ export const NewHeader = ({
               trigger="click"
               onShow={() => tagManagerEvent("alert_tooltip_clicked")}
             >
-              <div className="c-route-ladder__alert-icon">
-                <ExclamationTriangleFill aria-label="Route Alert" />
+              <div
+                className="c-route-ladder__alert-icon"
+                aria-label="Route Alert"
+              >
+                <ExclamationTriangleFill />
               </div>
             </Tippy>
           )}
@@ -251,30 +215,17 @@ const RouteLadder = ({
 
   return (
     <>
-      {inTestGroup(TestGroups.RouteLadderHeaderUpdate) ? (
-        <NewHeader
-          routeName={route.name}
-          hasAlert={hasAlert}
-          onClose={() => {
-            deselectRoute(route.id)
-          }}
-          showDropdown={
-            inTestGroup(TestGroups.DetoursPilot) &&
-            inTestGroup(TestGroups.DetourRouteSelection)
-          }
-          onClickAddDetour={() => {
-            onAddDetour?.(route)
-          }}
-        />
-      ) : (
-        <Header
-          routeName={route.name}
-          hasAlert={hasAlert}
-          onClose={() => {
-            deselectRoute(route.id)
-          }}
-        />
-      )}
+      <NewHeader
+        routeName={route.name}
+        hasAlert={hasAlert}
+        onClose={() => {
+          deselectRoute(route.id)
+        }}
+        showDropdown={inTestGroup(TestGroups.DetoursPilot)}
+        onClickAddDetour={() => {
+          onAddDetour?.(route)
+        }}
+      />
       <Controls
         displayCrowdingToggleIcon={displayCrowding}
         ladderDirection={ladderDirection}

diff --git a/assets/src/userInTestGroup.ts b/assets/src/userInTestGroup.ts
@@ -2,13 +2,11 @@ import getTestGroups from "./userTestGroups"
 
 export enum TestGroups {
   DemoMode = "demo-mode",
-  DetourRouteSelection = "detour-route-selection",
   DetoursPilot = "detours-pilot",
   DummyDetourPage = "dummy-detour-page",
   KeycloakSso = "keycloak-sso",
   MinimalLadderPage = "minimal-ladder-page",
   LateView = "late-view",
-  RouteLadderHeaderUpdate = "route-ladder-header-update",
 }
 
 const inTestGroup = (key: TestGroups): boolean => {

diff --git a/assets/stories/skate-components/routeLadderHeader.stories.tsx b/assets/stories/skate-components/routeLadderHeader.stories.tsx