refactor(ex/detours): refactor update_or_create_detour_for_user to …

…use Serde module
mbta · Nov 4, 2024 · f0b86b8 · f0b86b8
1 parent a815dba
commit f0b86b8
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 44 deletions.
diff --git a/lib/skate/detours/detours.ex b/lib/skate/detours/detours.ex
@@ -193,36 +193,33 @@ defmodule Skate.Detours.Detours do
   end
 
   @doc """
-  Update or create a detour given a user id & detour id.
+  Update or insert a detour given a user id and a XState Snapshot.
   """
-  def update_or_create_detour_for_user(user_id, uuid, attrs \\ %{}) do
-    user = User.get_by_id!(user_id)
-
-    previous_record = uuid != nil && Skate.Repo.get(Detour, uuid)
-
-    detour =
-      case uuid do
-        nil ->
-          create_detour_for_user(user_id, attrs)
-
-        _ ->
-          Repo.insert(
-            Detour.changeset(%Detour{author: user, id: uuid}, attrs),
-            returning: true,
-            conflict_target: [:id],
-            on_conflict: {:replace, [:state, :updated_at]}
-          )
+  def upsert_from_snapshot(author_id, %{} = snapshot) do
+    previous_record =
+      case Skate.Detours.SnapshotSerde.id_from_snapshot(snapshot) do
+        nil -> nil
+        id -> Skate.Repo.get(Detour, id)
       end
 
-    case detour do
+    detour_db_result =
+      author_id
+      |> Skate.Detours.SnapshotSerde.deserialize(snapshot)
+      |> Skate.Repo.insert(
+        returning: true,
+        conflict_target: [:id],
+        on_conflict: {:replace, [:state, :updated_at]}
+      )
+
+    case detour_db_result do
       {:ok, %Detour{} = new_record} ->
-        send_notification(new_record, previous_record, user_id)
+        send_notification(new_record, previous_record, author_id)
 
       _ ->
         nil
     end
 
-    detour
+    detour_db_result
   end
 
   @doc """

diff --git a/lib/skate_web/controllers/detours_controller.ex b/lib/skate_web/controllers/detours_controller.ex
@@ -11,15 +11,11 @@ defmodule SkateWeb.DetoursController do
   alias Util.Location
 
   @spec update_snapshot(Plug.Conn.t(), map()) :: Plug.Conn.t()
-  def update_snapshot(conn, %{"snapshot" => %{"context" => context} = snapshot}) do
-    uuid = Map.get(context, "uuid")
-
+  def update_snapshot(conn, %{"snapshot" => snapshot}) do
     %{id: user_id} = AuthManager.Plug.current_resource(conn)
 
     {:ok, %Skate.Detours.Db.Detour{id: returned_uuid}} =
-      Detours.update_or_create_detour_for_user(user_id, uuid, %{
-        state: snapshot
-      })
+      Detours.upsert_from_snapshot(user_id, snapshot)
 
     json(conn, %{data: returned_uuid})
   end

diff --git a/test/skate_web/controllers/detours_controller_test.exs b/test/skate_web/controllers/detours_controller_test.exs
@@ -280,23 +280,21 @@ defmodule SkateWeb.DetoursControllerTest do
       other_user = Skate.Settings.User.get_by_email("other_user@gmail.com")
 
       # Manually insert a detour by another user
-      Detours.update_or_create_detour_for_user(other_user.id, 10, %{
-        state: %{
-          "context" => %{
-            "route" => %{
-              "name" => "23",
-              "directionNames" => %{
-                "0" => "Outbound",
-                "1" => "Inbound"
-              }
-            },
-            "routePattern" => %{
-              "headsign" => "Headsign",
-              "directionId" => 0
-            },
-            "nearestIntersection" => "Street A & Avenue B",
-            "uuid" => 10
-          }
+      Detours.upsert_from_snapshot(other_user.id, %{
+        "context" => %{
+          "route" => %{
+            "name" => "23",
+            "directionNames" => %{
+              "0" => "Outbound",
+              "1" => "Inbound"
+            }
+          },
+          "routePattern" => %{
+            "headsign" => "Headsign",
+            "directionId" => 0
+          },
+          "nearestIntersection" => "Street A & Avenue B",
+          "uuid" => 10
         }
       })